[mlir][IntRange] Poison support in int-range analysis #152932
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode84
force-pushed
the
int-range-poison
branch
2 times, most recently
from
bc195a7 to
acd1e54
Compare
Hardcode84
force-pushed
the
int-range-poison
branch
from
acd1e54 to
f89476d
Compare
krzysz00
reviewed
Aug 12, 2025
| @@ -96,6 +103,14 @@ class ConstantIntRanges { | |||
| /// value. | |||
| std::optional<APInt> getConstantValue() const; | |||
|
|
|||
| /// Returns true if signed range is poisoned, i.e. no valid signed value | |||
There was a problem hiding this comment.
I don't think I agree with "no valid value" as the semantics here. We need to be much clearer that a poisoned range is one that's the result of undefined behavior, and this is assumed to be impossible.
| @@ -306,7 +329,8 @@ static ConstantIntRanges inferDivURange(const ConstantIntRanges &lhs, | |||
|
|
|||
| // X u/ Y u<= X. | |||
| APInt umax = lhsMax; | |||
| return ConstantIntRanges::fromUnsigned(umin, umax); | |||
| return propagatePoison(ConstantIntRanges::fromUnsigned(umin, umax), | |||
There was a problem hiding this comment.
Something feels off about the fact that you have to stick these calls everywhere, but maybe that's just how it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.